enabled KMS key rotation for the code present inside /examples folder tf files - tfsec failure

gankamat commented 4 months ago

Description

Motivation and Context

When we are using this module, we are seeing tfsec failures with error

.terraform/modules/rds_provisioned/examples/global-cluster/main.tf:195-200 resource "aws_kms_key" "secondary" { provider = aws.secondary policy = data.aws_iam_policy_document.rds.json tags = local.tags } See https://aquasecurity.github.io/tfsec/v1.28.5/checks/aws/kms/auto-rotate-keys/

Breaking Changes

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects
[ ] I have executed pre-commit run -a on my pull request

bryantbiggs commented 4 months ago

if your security scanner is highlighting an issue thats completely outside of any code path (its an example, its not in the module source code), then there is something amiss with either how you are consuming the module or the scanner itself

github-actions[bot] commented 3 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

terraform-aws-modules / terraform-aws-rds-aurora