search

terraform-aws-modules / terraform-aws-rds-aurora

Terraform module to create AWS RDS Aurora resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/rds-aurora/aws
Apache License 2.0
385 stars 573 forks source link

Passing null to `performance_insights_retention_period` is not being treated as not set #452

Closed stecullum closed 5 months ago

stecullum commented 5 months ago

Calling the module from another module ; unable to set [performance_insights_enabled : false ]

Passing null to performance_insights_retention_period is not being treated as not set

Error: creating RDS Cluster (Blob) Instance Blob: InvalidParameterCombination: To enable Performance Insights, EnablePerformanceInsights must be set to 'true'

For example,

module "dbase-1" {
   source my-module
   performance_insights_enabled = false 
   performance_insights_retention_period = null // aka not set
}

module "dbase-2" {
   source my-module
   performance_insights_enabled = true 
}

my-module
   ... get vars and pass to this module

module "aurora" {
  performance_insights_enabled          = false 
  performance_insights_retention_period = null # this is optional which null is ... i cannot remove the field in TF as its called by another module 
}
stecullum commented 5 months ago

My mistake

github-actions[bot] commented 4 months ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.