terraform-aws-modules / terraform-aws-rds-proxy

Terraform module to create AWS RDS Proxy resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/rds-proxy/aws
Apache License 2.0
56 stars 54 forks source link

feat: Add IAM role output #22

Closed mmclane closed 1 year ago

mmclane commented 1 year ago

Description

Adds an output for IAM role arn and updates the README.md to reflect this new output.

Motivation and Context

This allows you to reference the role used by the module. Since the module might create a new role you don't know what the new role's ARN is unless you look it up in some other way. This makes it easy to reference.

Breaking Changes

No, it shouldn't break anything.

How Has This Been Tested?

bryantbiggs commented 1 year ago

thanks - we should have exported this from the beginning. Can we copy this https://github.com/terraform-aws-modules/terraform-aws-ecs/blob/f2befd85b08c588ab2df4b515af187d2bb70c9e2/modules/cluster/outputs.tf#L57C1-L70C2 and use it here (update to match the correct name) to ensure the standard properties for the IAM role are exported

mmclane commented 1 year ago

thanks - we should have exported this from the beginning. Can we copy this https://github.com/terraform-aws-modules/terraform-aws-ecs/blob/f2befd85b08c588ab2df4b515af187d2bb70c9e2/modules/cluster/outputs.tf#L57C1-L70C2 and use it here (update to match the correct name) to ensure the standard properties for the IAM role are exported

I have updated the PR to include role name and unique_id to match what is being done in ECS

antonbabenko commented 1 year ago

This PR is included in version 3.1.0 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.