search

terraform-aws-modules / terraform-aws-s3-bucket

Terraform module to create AWS S3 resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/s3-bucket/aws
Apache License 2.0
526 stars 3.62k forks source link

Add more information about Canned ACLs to documentation #269

Closed rudolfolah closed 9 months ago

rudolfolah commented 10 months ago

The description for the acl option mentions "canned ACL": https://github.com/terraform-aws-modules/terraform-aws-s3-bucket/blob/master/variables.tf#L98

It would be useful to do one of the following:

  1. include a link to the AWS documentation related to the Canned ACL values: The canned ACL to apply: https://docs.aws.amazon.com/AmazonS3/latest/userguide/acl-overview.html
  2. include the possible values to the description: The canned ACL to apply: private, public-read, bucket-owner-read, ...
  3. capitalize the word "canned" and prefix it with "AWS": The AWS Canned ACL to apply.
github-actions[bot] commented 9 months ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] commented 9 months ago

This issue was automatically closed because of stale in 10 days

github-actions[bot] commented 8 months ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.