search

terraform-aws-modules / terraform-aws-s3-bucket

Terraform module to create AWS S3 resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/s3-bucket/aws
Apache License 2.0
526 stars 3.62k forks source link

Draft: Establish a dedicated "NIST Mode" for easing compliance #275

Closed apmarshall closed 8 months ago

apmarshall commented 8 months ago

Description

This PR introduces a new variable, nist_mode, which, when set to true overrides other variables within the module to guarantee certain values for compliance purposes.

In the context of this module, the changes made can be seen in the updates to the README, which documents both what requirements are being met and what variables are overridden to achieve this.

Motivation and Context

There are some environments, especially those in the government space, where adherence to NIST SP 800-53 standards is required. Rather than creating separate modules that enforce these requirements, this allows users in those environments to continue using these community supported modules by setting a single variable to ensure compliance requirements are met.

Breaking Changes

This should not introduce any breaking changes to uses who do not enable nist_mode. The default for nist_mode is set to false, which means that the module should continue to perform exactly as it currently does for users who have not enabled nist_mode. Enabling nist_mode overrides certain variables, as documented in the README, which could result in breaking changes for module implementations that would have been out of compliance before setting nist_mode to true.

How Has This Been Tested?

antonbabenko commented 8 months ago

Thank you for expressing interest. Closing for the same reasons as https://github.com/terraform-aws-modules/terraform-aws-kms/pull/29 .

PS: Shameless plug... https://compliance.tf is in development.

github-actions[bot] commented 7 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.