search

terraform-aws-modules / terraform-aws-security-group

Terraform module to create AWS Security Group resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/security-group/aws
Other
564 stars 1.08k forks source link

Security group list -> map -> resources? #313

Closed Lillecarl closed 7 months ago

Lillecarl commented 8 months ago

Is your request related to a new offering from AWS?

Is your request related to a problem? Please describe.

All security group rules are deleted and created if you remove the first entry

Describe the solution you'd like.

I tried an implementation using substring(sha265(jsonformat(object)), 0, 5) as key for a resource list and it worked well. It'll recreate instead of modify a rule if you change any value, but it wont affect other resources.

Describe alternatives you've considered.

Not using the module, it's not too many resource types, dependencies and stuff anyways.

Additional context

Thanks for all your work 😄

antonbabenko commented 8 months ago

I am aware of this as a limitation, unfortunately.

This feature requires a big rewrite of the module, which currently needs to be planned.

github-actions[bot] commented 7 months ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

Lillecarl commented 7 months ago

Acknowledgement is good enough :)

github-actions[bot] commented 6 months ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.