terraform-aws-modules / terraform-aws-security-group

Terraform module to create AWS Security Group resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/security-group/aws
Other
562 stars 1.08k forks source link

feat: Allow the creation of prefix-list rules, passing in unique prefix list IDs on a per rule basis #318

Closed mission-coliveros closed 5 months ago

mission-coliveros commented 7 months ago

Description

This PR is meant to address the complaints in this open issue

Motivation and Context

The existing codebase does not allow the creation of prefix-list based rules, where you can pass in prefix list IDs on a per-rule basis. You can only assign prefix list IDs at the module level, which is not particularly helpful.

Breaking Changes

Default values have been implemented, with the intention of not introducing any breaking changes

How Has This Been Tested?

I can start testing with examples, but I'd like to wait and see if this PR gets shut down before I put any more effort into it.

github-actions[bot] commented 6 months ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] commented 5 months ago

This PR was automatically closed because of stale in 10 days

github-actions[bot] commented 4 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.