Switch to using aws_vpc_security_group_egress_rule and aws_vpc_security_group_ingress_rule

[mhowell-ims]

Is your request related to a new offering from AWS?

Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too.

• Yes ✅: available since 4.56.0

Is your request related to a problem? Please describe.

These newer resources types now seem to be the recommended way to create SG rules. Excerpt from the docs for these newer resources:

Terraform currently provides a Security Group resource with ingress and egress rules defined in-line and a Security Group Rule resource which manages one or more ingress or egress rules. Both of these resource were added before AWS assigned a security group rule unique ID, and they do not work well in all scenarios using the description and tags attributes, which rely on the unique ID. The aws_vpc_security_group_egress_rule resource has been added to address these limitations and should be used for all new security group rules. You should not use the aws_vpc_security_group_egress_rule resource in conjunction with an aws_security_group resource with in-line rules or with aws_security_group_rule resources defined for the same Security Group, as rule conflicts may occur and rules will be overwritten.

Describe the solution you'd like.

Switch to using these newer resource types for the rules instead of the older one, or perhaps provide an option to choose which ones to use.

Describe alternatives you've considered.

Additional context

[github-actions[bot]]

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

[github-actions[bot]]

This issue was automatically closed because of stale in 10 days

[phene]

This is a legit issue and I won't be using this module because it uses deprecated resources.

[mhowell-ims]

@antonbabenko I also believe this is a legit issue, can this be re-opened?