fix: Create only one transit gateway route table

cunymatthieu commented 1 year ago

Description

Do not create the Transit Gateway route table if the Transit Gateway default route table is set.

Transit Gateway default route table is set when enable_default_route_table_association and enable_default_route_table_propagation are true

Motivation and Context

When you want to create a transit gateway with this module, a TransitGateway is created by default (by terraform). But if we decide to use the Transit Gateway route table that will be created by AWS when the attributes (enable_default_route_table_association enable_default_route_table_propagation) are set to true, then this aws_ec2_transit_gateway_route_table route table is no longer necessary.

The goal is not to create an unused route table.

Breaking Changes

There should be no bad effect on backwards compatibility.

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

github-actions[bot] commented 1 year ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] commented 1 year ago

This PR was automatically closed because of stale in 10 days

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

terraform-aws-modules / terraform-aws-transit-gateway