fix: Defined dependencies: RAM_share_accepter<-TGW<-AWS_route

[yyarmoshyk]

Description

Defined dependencies: aws_ram_resource_share_accepter<-aws_ec2_transit_gateway_vpc_attachment<-aws_route.this

Motivation and Context

I was using this module to wire the transit gateway from one account to another (peer account) and the code fails to create route table in peer VPC because of the missing resource ordering. It creates route table in peering VPC before accepting the RAM share and TGW attachment to the VPC.

Terragrunt apply fails with the following error:

module.tgw.aws_route.this["rtb-111111"]: Still creating... [4m50s elapsed]
╷
│ Error: creating EC2 Transit Gateway VPC Attachment: InvalidTransitGatewayID.NotFound: Transit Gateway tgw-111111111 was deleted or does not exist.
│   status code: 400, request id: 92dda22e-9e61-43e6-bab7-e2fe1744f0d0
│ 
│   with module.tgw.aws_ec2_transit_gateway_vpc_attachment.this["dev"],
│   on .terraform/modules/tgw/main.tf line 66, in resource "aws_ec2_transit_gateway_vpc_attachment" "this":
│   66: resource "aws_ec2_transit_gateway_vpc_attachment" "this" {
│ 
╵
╷
│ Error: creating Route in Route Table (rtb-111111) with destination (0.0.0.0/0): InvalidTransitGatewayID.NotFound: The transitGateway ID 'tgw-08c63a2acff677f14' does not exist.
│   status code: 400, request id: 5ac5d791-8be1-474e-b625-a3bf95cc369b
│ 
│   with module.tgw.aws_route.this["rtb-111111"],
│   on .terraform/modules/tgw/main.tf line 113, in resource "aws_route" "this":
│  113: resource "aws_route" "this" {

Breaking Changes

No.

How Has This Been Tested?

• The examples/* should not be updated
• I build my case using the examples and tested it by creating TGW in shared AWS account (#1) with subsequent apply to DEV AWS account (#2 - peer). Here is the order how resources are being created in peering account:

  module.tgw.aws_ram_resource_share_accepter.this[0]: Creating...
  module.tgw.aws_ram_resource_share_accepter.this[0]: Creation complete after 4s [id=arn:aws:ram:us-west-1:11111111:resource-share/111111]
  module.tgw.aws_ec2_transit_gateway_vpc_attachment.this["dev"]: Creating...
  module.tgw.aws_ec2_transit_gateway_vpc_attachment.this["dev"]: Still creating... [10s elapsed]
  ...
  module.tgw.aws_ec2_transit_gateway_vpc_attachment.this["dev"]: Still creating... [1m40s elapsed]
  module.tgw.aws_ec2_transit_gateway_vpc_attachment.this["dev"]: Creation complete after 1m48s [id=tgw-attach-1111]
  module.tgw.aws_route.this["rtb-1111"]: Creating...
  module.tgw.aws_route.this["rtb-1111"]: Creating...
  module.tgw.aws_route.this["rtb-1111"]: Creation complete after 2s [id=r-rtb-1111]

• I have executed pre-commit run -a on my pull request

p.s.: putin - Huilo.

[github-actions[bot]]

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

[github-actions[bot]]

This PR was automatically closed because of stale in 10 days

[github-actions[bot]]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.