search

terraform-aws-modules / terraform-aws-vpc

Terraform module to create AWS VPC resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/vpc/aws
Apache License 2.0
2.99k stars 4.44k forks source link

feat: Add NAT gateway interface ids output #1006

Closed tormodmacleod closed 11 months ago

tormodmacleod commented 1 year ago

Description

Added output of Network Interface IDs assigned to NAT Gateways

Motivation and Context

We send our flow logs to New Relic. This would save me having to use a data resource to get the network interface IDs as below

data "aws_nat_gateway" "nat_gateway" {
  for_each = toset(module.vpc.natgw_ids)

  id = each.value
}

Breaking Changes

No, there should be no backwards compatibility issues resulting from this change

How Has This Been Tested?

I tested this locally by changing the source of one of my projects which uses the vpc module

github-actions[bot] commented 11 months ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

antonbabenko commented 11 months ago

This PR is included in version 5.3.0 :tada:

github-actions[bot] commented 10 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.