terraform-aws-modules / terraform-aws-vpc

Terraform module to create AWS VPC resources πŸ‡ΊπŸ‡¦
https://registry.terraform.io/modules/terraform-aws-modules/vpc/aws
Apache License 2.0
2.99k stars 4.44k forks source link

VPC Flow Log Kinesis Firehose Support #1013

Closed kclinden closed 10 months ago

kclinden commented 11 months ago

Is your request related to a new offering from AWS?

Is this functionality available in the AWS provider for Terraform?

Is your request related to a problem? Please describe.

No

Describe the solution you'd like.

Update variable description to support kinesis firehose.

Describe alternatives you've considered.

it already works, but updating to make it clear

Additional context

The current module doesn't mention the support of vpc flow logs to kinesis firehose, but this was added back in Sept 2022.

kclinden commented 11 months ago

Looks like we are also not exposing parameter deliver_cross_account_role in order to support cross-account vpc flow.

kclinden commented 11 months ago

Tested this in my local environment:

  #Flowlog Fun
  enable_flow_log                  = true
  flow_log_destination_type        = "kinesis-data-firehose"
  flow_log_traffic_type            = "ALL"
  flow_log_destination_arn         = "arn:aws:firehose:us-east-1:<dest_acount_id>>:deliverystream/<dest_firehose_name>"
  deliver_cross_account_role       = "arn:aws:iam::<dest_acount_id>>:role/AWSLogDeliveryFirehoseCrossAccountRole"
  flow_log_cloudwatch_iam_role_arn = "arn:aws:iam::<source_account>>:role/<source_role_name>"
github-actions[bot] commented 10 months ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] commented 10 months ago

This issue was automatically closed because of stale in 10 days

github-actions[bot] commented 9 months ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.