chore: Fix misconfigured IAM policies in examples/complete

terraform-aws-modules / terraform-aws-vpc

Terraform module to create AWS VPC resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/vpc/aws

Apache License 2.0

2.99k stars 4.44k forks source link

chore: Fix misconfigured IAM policies in examples/complete #1021

Closed enm10k closed 11 months ago

enm10k commented 11 months ago

Description

Fixed misconfigured IAM policies in examples/complete

Motivation and Context

I created a VPC Endpoints based on examples/complete, but it did not work due to misconfigured IAM policies.

Breaking Changes

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects
[ ] I have executed pre-commit run -a on my pull request

bryantbiggs commented 11 months ago

they are not mis-configured because they are merely examples - users will need to adjust the policies based on their business requirements

said differently - we have examples that create S3 buckets but the buckets are not encrypted. Is this mis-configured? I would argue no because there is no context other than they are examples for demonstration and testing purposes; users will need to configure the appropriate settings for their individual requirements

enm10k commented 11 months ago

Thanks for your explanation. I understand what you are saying.

At first glance, the current IAM policies seem to allow operations from the VPC, but it actually operates to deny all actions. I thought it was confusing, but as you say, it might not be a problem as examples.

github-actions[bot] commented 10 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.