feat: Add support for `dns_options` on VPC endpoints

terraform-aws-modules / terraform-aws-vpc

Terraform module to create AWS VPC resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/vpc/aws

Apache License 2.0

2.99k stars 4.44k forks source link

feat: Add support for `dns_options` on VPC endpoints #1023

Closed erezo9 closed 10 months ago

erezo9 commented 11 months ago

Description

add dns_options block to use it in cases of endpoints that support gateway and interface

Motivation and Context

Resolves #982

Breaking Changes

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[X] I have tested and validated these changes using one or more of the provided examples/* projects
there is no user input change, if the array is not existend or private_dns_enabled is false it will not trigger a change

tested locally
[x] I have executed pre-commit run -a on my pull request

erezo9 commented 11 months ago

@antonbabenko if you could please review this or tag relavent people to review will be super helpful if this be in the next version

erezo9 commented 10 months ago

@bryantbiggs Can you please review this MR, i cant assign reviewers to view this code and it will really help in the provisioning

antonbabenko commented 10 months ago

This PR is included in version 5.5.0 :tada:

erezo9 commented 10 months ago

@bryantbiggs thanks for merging why did you change the looping validation and the check on the private_dns_enabled? i added it so it could prevent users from using this when its type gateway and when private_dns_enabled = true the value should not exist

bryantbiggs commented 10 months ago

the value should not exist

Then users should not provide it. Sometimes we can provide the means to help users avoid misconfiguration, but in this scenario the logic would be overly complex

github-actions[bot] commented 9 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.