search

terraform-aws-modules / terraform-aws-vpc

Terraform module to create AWS VPC resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/vpc/aws
Apache License 2.0
2.99k stars 4.44k forks source link

feat: Support for multiple public route tables #1025

Closed piartz closed 8 months ago

piartz commented 10 months ago

Description

Support for multiple route tables when creating public subnets

Motivation and Context

Guarantee that the used route table for public subnets on creation is different when a boolean variable is set to true. Motivation from issue https://github.com/terraform-aws-modules/terraform-aws-vpc/issues/1020

Breaking Changes

No breaking changes, as the variable is optional and defaulted to 'false'.

How Has This Been Tested?

Used the examples/simple/* directory as a start. Changed the private_subnets array for public_subnets and verified that the behavior described by the requester is happening. Included the variable create_multiple_public_route_tables and set to true. Verified in multiple runs of apply and destroy that the created route table is different for each new public subnet.

Changes to examples/simple/ have not been reflected on the push. I also did not want to copy-paste the contents of 'simple' for this use case, for a more clean, less complex state of the examples folder. Please let me know if you prefer the example to be included.

github-actions[bot] commented 9 months ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

piartz commented 9 months ago

upping the PR so it is not stale anymore

github-actions[bot] commented 8 months ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] commented 8 months ago

This PR was automatically closed because of stale in 10 days

github-actions[bot] commented 7 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.