terraform-aws-modules / terraform-aws-vpc

Terraform module to create AWS VPC resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/vpc/aws
Apache License 2.0
2.97k stars 4.42k forks source link

feat: Add support for multiple route tables to public and intra subnets #1051

Closed KevinSnyderCodes closed 5 months ago

KevinSnyderCodes commented 7 months ago

Description

Support for multiple route tables when creating public and intra subnets.

Motivation and Context

Guarantee that the used route table for public and intra subnets on creation is different when a boolean variable is set to true.

Breaking Changes

No breaking changes, as the variables are optional and defaulted to false.

How Has This Been Tested?

KevinSnyderCodes commented 6 months ago

@bryantbiggs Any interest in introducing this feature to the module? I'm happy to update the examples and finalize this PR if this is something you'd be open to merging.

Smana commented 6 months ago

tf-controller plan output:


No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

To apply this plan, please merge this pull request.

adubkov commented 5 months ago

Any movements on this? Would love to have it.

antonbabenko commented 5 months ago

This PR is included in version 5.8.0 :tada:

github-actions[bot] commented 4 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.