terraform-aws-modules / terraform-aws-vpc

Terraform module to create AWS VPC resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/vpc/aws
Apache License 2.0
2.92k stars 4.36k forks source link

Enable the setup of fully private NAT Gateways #1060

Closed laserpedro closed 1 month ago

laserpedro commented 2 months ago

Is your request related to a new offering from AWS?

Is your request related to a problem? Please describe.

The module enables to setup VPCs following AWS best practices and I think that it should enable to implement the private NAT Gateway setup

Describe the solution you'd like.

Expose the variables that enables the setup referenced above. So add the connectivity_type and the other arguments relative to the setup of a private NAT Gateway.

I would be glad to create the pull request myself I you see any interest in this feature request. I believe that the fully private NAT Gateway can be a classic company setup and therefore we should enable this feature.

Workaround

The current workaround is to simply create the private NAT Gateway outside of the module and specifying the connectivity_type to private.

bryantbiggs commented 2 months ago

if you have a PR, we can take a look

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] commented 1 month ago

This issue was automatically closed because of stale in 10 days