terraform-aws-modules / terraform-aws-vpc

Terraform module to create AWS VPC resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/vpc/aws
Apache License 2.0
2.92k stars 4.36k forks source link

feat: Enable the creation of private NAT gateways #1072

Closed laserpedro closed 1 week ago

laserpedro commented 2 months ago

fixes #1060

Description

Enable the setup of private NAT Gateways by exposing the native resource argument connectivity_type and the related arguments.

Motivation and Context

If the module is used in the context of corporate network setup, a private nat gateway can be required since we are not created and internet gateway in the vpc.

How Has This Been Tested?

laserpedro commented 1 month ago

Hello @bryantbiggs ! Did you have the time to have a look at my PR ? Thank you !

andre-lx commented 1 month ago

Hi @laserpedro

Nice job.

Just one question, I was checking and the support for private nat gw is something I am looking forward in the module, unfortunately this does not take in account some scenarios where you can have public nat gw on your public subnets and private nat gw on you private subnets right?

Thanks

laserpedro commented 1 month ago

Hi @andre-lx ,

Thank you for your comment, much appreciated. So in this fully private NAT Gateway configuration, we would not create an IGW so you could not have a mix of public and private nat. If I am correct, you would like to have some nat created in subnets with a route to the igw (the public ones) and others created in the subnets in subnet with a route with the tgw (the private ones) ?

github-actions[bot] commented 3 weeks ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] commented 1 week ago

This PR was automatically closed because of stale in 10 days