search

terraform-aws-modules / terraform-aws-vpc

Terraform module to create AWS VPC resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/vpc/aws
Apache License 2.0
2.92k stars 4.36k forks source link

fix: NAT gw route table associations shouldn't be created when enable_nat_gateway=false #1090

Open kkonstant-in opened 4 weeks ago

kkonstant-in commented 4 weeks ago

Description

Fixes creating NAT gateway route table associations even when enable_nat_gateway=false

Motivation and Context

More detailed description of the issue is here https://github.com/terraform-aws-modules/terraform-aws-vpc/issues/1031

Breaking Changes

no breaking changes

How Has This Been Tested?

Tested in production TGW environment with no NAT gw route table associations

kkonstant-in commented 2 weeks ago

Hi there.

@bryantbiggs do you need a more detailed description or anything else for this issue? Looks like a simple fix, isn't it?