feat: Allow option of not creating route to NAT in private subnets

terraform-aws-modules / terraform-aws-vpc

Terraform module to create AWS VPC resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/vpc/aws

Apache License 2.0

2.99k stars 4.44k forks source link

feat: Allow option of not creating route to NAT in private subnets #1098

Closed euhn-gp closed 3 months ago

euhn-gp commented 4 months ago

Description

Allow option in whether or not to create a route to the NAT gateway in private subnets.

Motivation and Context

There are use cases where the creation of this route is undesired. One example is in the use of a VPC network firewall, where the route destination would be the VPC endpoint of the firewall.

Breaking Changes

No breaking changes.

How Has This Been Tested?

[ x ] I have tested and validated these changes in a VPC in my own environment
[ x ] I have executed pre-commit run -a on my pull request

github-actions[bot] commented 3 months ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] commented 3 months ago

This PR was automatically closed because of stale in 10 days

github-actions[bot] commented 2 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.