feat: Add route to `0.0.0.0/0` & `::/0` (when IPv6 is enabled) on all public route tables

terraform-aws-modules / terraform-aws-vpc

Terraform module to create AWS VPC resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/vpc/aws

Apache License 2.0

2.99k stars 4.44k forks source link

feat: Add route to `0.0.0.0/0` & `::/0` (when IPv6 is enabled) on all public route tables #1100

Closed abohne closed 3 months ago

abohne commented 4 months ago

Description

Makes the count on aws_route dynamic instead of fixed at 1

Motivation and Context

Fixes #1087

Breaking Changes

Not that I'm aware of.

How Has This Been Tested?

[X] I have tested and validated these changes in a VPC in my environment that have a single public route table as well as another VPC that has multiple public route tables
[X] I have executed pre-commit run -a on my pull request

github-actions[bot] commented 3 months ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

antonbabenko commented 3 months ago

This PR is included in version 5.11.0 :tada:

github-actions[bot] commented 2 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.