terraform-aws-modules / terraform-aws-vpc

Terraform module to create AWS VPC resources πŸ‡ΊπŸ‡¦
https://registry.terraform.io/modules/terraform-aws-modules/vpc/aws
Apache License 2.0
2.96k stars 4.41k forks source link

transit gateway subnets for attachment of vpc #888

Closed dingersoll722 closed 1 year ago

dingersoll722 commented 1 year ago

Is your request related to a new offering from AWS?

Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too.

Is your request related to a problem? Please describe.

As part of the AWS best practice design for attaching a Transit Gateway it suggests creating a separate subnet

Use a separate subnet for each transit gateway VPC attachment. For each subnet, use a small CIDR, for example /28, so that you have more addresses for EC2 resources. When you use a separate subnet, you can configure the following:

Keep the inbound and outbound network ACLs associated with the transit gateway subnets open.

Depending on your traffic flow, you can apply network ACLs to your workload subnets.

https://docs.aws.amazon.com/vpc/latest/tgw/tgw-best-design-practices.html

Describe the solution you'd like.

add a set of subnet resources that create this set of subnets - and then set that to be used with the TGW module for attachments in the VPC?

Describe alternatives you've considered.

I create these outside of the module - but then incorporating them into the TGW module is an issue

Additional context

None right now

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] commented 1 year ago

This issue was automatically closed because of stale in 10 days

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.