terraform-aws-modules / terraform-aws-vpc

Terraform module to create AWS VPC resources πŸ‡ΊπŸ‡¦
https://registry.terraform.io/modules/terraform-aws-modules/vpc/aws
Apache License 2.0
2.99k stars 4.44k forks source link

Add Carrier Gateway support + Wavelength Zone subnet support for AWS Wavelength #893

Closed rhbelson closed 1 year ago

rhbelson commented 1 year ago

Is your request related to a new offering from AWS?

Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too.

Is your request related to a problem? Please describe.

Describe the solution you'd like.

Describe alternatives you've considered.

Additional context

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

ForbiddenEra commented 1 year ago

You can actually add wavelength zone subnets; however there IS a bug (see my annoyingly auto-closed "stale" issue at #864) that doesn't allow this to work if using IPv6/dualstack at all because WLZ doesn't do IPv6 and it breaks the module.

ForbiddenEra commented 1 year ago

Bump before stale again, reminding that my issue #864 was closed, I can't re-open and I don't really want to create a new one for it and this is kinda related.

ForbiddenEra commented 1 year ago

I think #892 could be considered as a potential way forward for handling subnets; if not exactly how suggested there, at least improving the flexibility should be considered especially in cases like this where one wants to use WLZ and IPv6 together or otherwise.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] commented 1 year ago

This issue was automatically closed because of stale in 10 days

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.