fix: WIP: Separate IGW creation from VPC attachment

terraform-aws-modules / terraform-aws-vpc

Terraform module to create AWS VPC resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/vpc/aws

Apache License 2.0

2.99k stars 4.44k forks source link

fix: WIP: Separate IGW creation from VPC attachment #896

Closed onitake closed 1 year ago

onitake commented 1 year ago

Description

This PR separates creation of the internet gateway (IGW) from attachment to the VPC.

By doing this, an implicit dependency is avoided, allowing terraform destroy on a VPC+IGW created by this module.

Motivation and Context

Fixes: #883

Breaking Changes

The new resource aws_internet_gateway_attachment requires version 4.3.0 of the Terraform provider for AWS.

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects
[ ] I have executed pre-commit run -a on my pull request

onitake commented 1 year ago

As written in #883 , I couldn't reproduce the issue with the simple-vpc example and a custom test case with the current version of the AWS provider. However, I'm still experiencing the dependency problem in a production environment. Further testing is needed.

github-actions[bot] commented 1 year ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] commented 1 year ago

This PR was automatically closed because of stale in 10 days

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.