improvement: allow custom network ACL for specific subnets

terraform-aws-modules / terraform-aws-vpc

Terraform module to create AWS VPC resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/vpc/aws

Apache License 2.0

2.99k stars 4.44k forks source link

improvement: allow custom network ACL for specific subnets #899

Closed samuel-phan closed 1 year ago

samuel-phan commented 1 year ago

fix #898

Description

Motivation and Context

Breaking Changes

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects
[ ] I have executed pre-commit run -a on my pull request

bryantbiggs commented 1 year ago

this is an incorrect implementation - we can continue to discuss in the issue linked before any changes are proposed

samuel-phan commented 1 year ago

OK, I just wanted to show a little bit further what I meant into concrete code, just to clarify my intentions.

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.