terraform-aws-modules / terraform-aws-vpc

Terraform module to create AWS VPC resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/vpc/aws
Apache License 2.0
2.99k stars 4.44k forks source link

fix: Add dns64 routes #924

Closed mikesplain closed 1 year ago

mikesplain commented 1 year ago

Description

Based on the nat64/dns64 docs, a route is required to utilize dns64 & nat64 for IPv6 only services to non-IPv6 services.

Motivation and Context

Fixes #923

Breaking Changes

How Has This Been Tested?

I tested this both in our internal stack and against the ipv6-dualstack example. New route should be created as long as nat gateways are enabled other criteria you'll see in the PR.

I only updated private subnet route tables and database subnet route tables since it seemed to fit the existing patterns but if I missed anything or you feel differently, I'm open to any suggestions. Thanks!

github-actions[bot] commented 1 year ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

mikesplainsonos commented 1 year ago

@bryantbiggs Mind taking a look at this PR when you have a moment? Thanks!

antonbabenko commented 1 year ago

This PR is included in version 4.0.2 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.