terraform-aws-modules / terraform-aws-vpc

Terraform module to create AWS VPC resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/vpc/aws
Apache License 2.0
2.99k stars 4.44k forks source link

fix: Ignore additional tags added for VPC and subnets outside the module. #985

Closed gohmc closed 1 year ago

gohmc commented 1 year ago

Description

Currently, additional tags added to VPC and subnet resources outside the module will be remove when re-apply, even there's no change to the network topology. To prevent tags from removal unexpectedly, this PR added lifecycle ignore_changes to tags for resource aws_vpc and aws_subnet.

Steps to reproduce the behavior:

Motivation and Context

Additional tags can be added post applied.

Breaking Changes

No.

How Has This Been Tested?

antonbabenko commented 1 year ago

This will not make it into the module because we want users to be able to manage tags across resources created by this module.

Closes #986

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.