Only do gateway attachments when we are actually creating

terraform-aws-modules / terraform-aws-vpn-gateway

Terraform module to create AWS VPN gateway resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/vpn-gateway/aws

Apache License 2.0

111 stars 156 forks source link

Only do gateway attachments when we are actually creating #10

Closed jmahowald closed 6 years ago

miguelaferreira commented 6 years ago

Hi @jmahowald, thanks for the PR. It LGTM, but I'll check this branch out, test it and then merge it. Please allow me some time for this.

miguelaferreira commented 6 years ago

I've tested with vpn_create_connection = true and vpn_create_connection = false and got the expected results in both cases.

@antonbabenko could you please merge?

antonbabenko commented 6 years ago

Thank you guys for the PR and review!

v1.4.0 has been released

github-actions[bot] commented 2 years ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.