terraform-aws-modules / terraform-aws-vpn-gateway

Terraform module to create AWS VPN gateway resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/vpn-gateway/aws
Apache License 2.0
111 stars 156 forks source link

feat: Added dpd_timeout_seconds variable to the "default" tunnel resource #51

Closed danielgadd closed 3 years ago

danielgadd commented 3 years ago

Exposed the tunnel1_dpd_timeout_seconds and tunnel2_dpd_timeout_seconds module parameters to the "default" AWS managed aws_vpn_connection resource.

Description

The change adds the tunnel1_dpd_timeout_seconds and tunnel2_dpd_timeout_seconds\ parameters to the default aws_vpn_connection resource as its appears to have been missed.

Motivation and Context

This was added because it appears to have been missed off PR #46

Breaking Changes

None that I have discovered.

How Has This Been Tested?

I have tested this change against my own implementation using this module.

antonbabenko commented 3 years ago

Thanks, @danielgadd !

v2.8.0 has been just released.

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.