search

terraform-aws-modules / terraform-aws-vpn-gateway

Terraform module to create AWS VPN gateway resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/vpn-gateway/aws
Apache License 2.0
111 stars 154 forks source link

feat: add local and remote ipv4 network cidr #53

Closed tomoatki closed 2 years ago

tomoatki commented 3 years ago

Description

This PR adds additonal inputs for the vpn-gateway module requested in issue https://github.com/terraform-aws-modules/terraform-aws-vpn-gateway/issues/44 namely additonal inputs of local_ipv4_network_cidr and remote_ipv4_network_cidr

tomoatki commented 3 years ago

Note: tflint complains that it is because there is a variable that is unused but given that the variable is meant to be optiional I assume this is ok?

antonbabenko commented 3 years ago

In order to finish this PR, we need to update terraform code to use variables added by this PR and update the minimum version of AWS provider in versions.tf.

Please revert changes in README. pre-commit run -a will update the documentation according to those markers.

github-actions[bot] commented 2 years ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] commented 2 years ago

This PR was automatically closed because of stale in 10 days

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.