search

terraform-aws-modules / terraform-aws-vpn-gateway

Terraform module to create AWS VPN gateway resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/vpn-gateway/aws
Apache License 2.0
111 stars 154 forks source link

feat: adding preshared key outputs to module #55

Closed tomoatki closed 3 years ago

tomoatki commented 3 years ago

Description

adding preshared keys as outputs

Motivation and Context

Helping with clean output of module

based on https://github.com/terraform-aws-modules/terraform-aws-vpn-gateway/issues/40

tomoatki commented 3 years ago

Added precommit syntax just to help with the testing happy to remove after it has been merged in under this PR or the other one :)

tomoatki commented 3 years ago

@antonbabenko this okay?

antonbabenko commented 3 years ago

Thanks! v2.10.0 has been just released.

vkanelov commented 2 years ago

Adding preshared key outputs to module makes my project fails, because preshared by default is sensitive data. Problem is this output is not deescalated as sensitive and apply fails when preshared is declarated as sensitive...

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.