feat: Add support for local and remote ipv4 cidr

terraform-aws-modules / terraform-aws-vpn-gateway

Terraform module to create AWS VPN gateway resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/vpn-gateway/aws

Apache License 2.0

111 stars 156 forks source link

feat: Add support for local and remote ipv4 cidr #58

Closed juho9000 closed 3 years ago

juho9000 commented 3 years ago

Description

Add support for local_ipv4_network_cidr remote_ipv4_network_cidr parameters of aws_vpn_connection resource

Motivation and Context

https://github.com/terraform-aws-modules/terraform-aws-vpn-gateway/issues/44

Breaking Changes

Not exactly a breaking change, but maybe good to know; Running pre-commit updates the provider in docs to the one from Terraform lockfile, see: https://github.com/terraform-docs/terraform-docs/issues/517

How Has This Been Tested?

[x] I have tested and validated these changes using one or more of the provided examples/* projects

lgallard commented 3 years ago

@antonbabenko any update on this PR?

khos2ow commented 3 years ago

FYI we've just released terraform-docs v0.15.0 which allows for ignoring reading .terraform.lock.hcl. This PR can partially be updated to incorporate the new change, or just leave it as is.

juho9000 commented 3 years ago

Thanks for reviewing, I've changed the default values to used AWS defaults as suggested.

antonbabenko commented 3 years ago

Thanks @juho9000 !

@khos2ow Next week we will probably discuss and then implement a better solution for the terraform-docs. Thanks for your feedback!

v2.11.0 has been just released.

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.