terraform-aws-modules / terraform-aws-vpn-gateway

Terraform module to create AWS VPN gateway resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/vpn-gateway/aws
Apache License 2.0
111 stars 154 forks source link

feat: Add outside_ip_address_type argument to aws_vpn_connection resources #75

Closed gladavius closed 1 year ago

gladavius commented 1 year ago

Description

Add the argument outside_ip_address_type to vpn resources

Motivation and Context

Since the release of this new feature it's now possible to create a priate s2s vpn over direct connect.

This PR aim to provide this feature but keep the default value to public in order to avoid disturbance for existing connections.

A new minimal example with this feature turned on has been added.

Breaking Changes

No

How Has This Been Tested?

github-actions[bot] commented 1 year ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] commented 1 year ago

This PR was automatically closed because of stale in 10 days

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.