terraform-aws-modules / terraform-aws-vpn-gateway

Terraform module to create AWS VPN gateway resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/vpn-gateway/aws
Apache License 2.0
111 stars 156 forks source link

feat: Add logging #76

Closed diego-ojeda-binbash closed 1 year ago

diego-ojeda-binbash commented 2 years ago

Description

Add logging support by introducing 2 new variables:

Motivation and Context

Logging is very useful for troubleshooting.

Breaking Changes

There shouldn't be any as the new variables have safe defaults.

How Has This Been Tested?

ZeroDeth commented 2 years ago

Hi, Any update about merging PR?

antonbabenko commented 1 year ago

Thank you, everyone! :)

antonbabenko commented 1 year ago

This PR is included in version 3.1.0 :tada:

nicon89 commented 1 year ago

In me-central-1 where logging is not enabled this is causing update on each apply:

      + tunnel1_log_options {
          + cloudwatch_log_options {
              + log_enabled       = (known after apply)
              + log_group_arn     = (known after apply)
              + log_output_format = (known after apply)
            }
        }

      + tunnel2_log_options {
          + cloudwatch_log_options {
              + log_enabled       = (known after apply)
              + log_group_arn     = (known after apply)
              + log_output_format = (known after apply)
            }
        }

Is there a way to disable it?

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.