search

terraform-aws-modules / terraform-aws-vpn-gateway

Terraform module to create AWS VPN gateway resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/vpn-gateway/aws
Apache License 2.0
111 stars 154 forks source link

Output refers to sensitive values #80

Closed avysotsk closed 1 year ago

avysotsk commented 1 year ago

Version of module 3.0.1 ❯ terraform --version Terraform v1.3.4 on darwin_amd64

Error message after apply

│ Error: Output refers to sensitive values │ │ on outputs.tf line 81: │ 81: output "vpn_connection_customer_gateway_configuration" { │ │ To reduce the risk of accidentally exporting sensitive data that was │ intended to be only internal, Terraform requires that any root module │ output containing sensitive data be explicitly marked as sensitive, to │ confirm your intent. │ │ If you do intend to export this data, annotate the output value as │ sensitive by adding the following argument: │ sensitive = true

amontalban commented 1 year ago

I'm having the exact same issue.

amontalban commented 1 year ago

@antonbabenko looks like this has been addressed in multiple PRs but none of them were merged:

Any chance you can help us by adding that line to the output so we don't have to use a fork for this?

Thanks!

stefan-matic commented 1 year ago

Experiencing same issue. Setting the vpn_connection_customer_gateway_configuration output with sensitive = true resolves the problem.

stefan-matic commented 1 year ago

@antonbabenko Do we have anyone that can verify these changes and accept a PR for it?

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

davidferguson-cr commented 1 year ago

Also seeing this so let's keep it open. I believe we should also be marking the pre-shared key outputs below as sensitive = true?

stefan-matic commented 1 year ago

@davidferguson-cr Yeah, I believe so. I could add one more commit but waiting for some response from maintainers if we want to implement it this way.

antonbabenko commented 1 year ago

This issue has been resolved in version 3.2.0 :tada:

antonbabenko commented 1 year ago

Thank you all for following up on this one!

davidferguson-cr commented 1 year ago

@antonbabenko Thanks! But what about the PSK outputs? Should I open a new issue/PR?

antonbabenko commented 1 year ago

@davidferguson-cr Yes, please open a PR for two PSKs.

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.