terraform-aws-modules / terraform-aws-vpn-gateway

Terraform module to create AWS VPN gateway resources πŸ‡ΊπŸ‡¦
https://registry.terraform.io/modules/terraform-aws-modules/vpn-gateway/aws
Apache License 2.0
111 stars 154 forks source link

Add variable for Name tag #81

Closed nicon89 closed 1 year ago

nicon89 commented 1 year ago

Is your request related to a new offering from AWS?

Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too.

Describe the solution you'd like.

I have multiple VPN connections and name "VPN Connection between VPC vpc-zyx and Customer Gateway cgw-xyz" doesn't tell much. Do you think you can variablize it with default option set as it is right now?

Describe alternatives you've considered.

Additional context

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

gartemiev commented 1 year ago

@bryantbiggs @antonbabenko @dynamike ,

is this something which you can do? There was already another request for this opened in the end of 2021 but it was ignored and closed automatically: https://github.com/terraform-aws-modules/terraform-aws-vpn-gateway/issues/61

antonbabenko commented 1 year ago

Name tag can be overridden using tags argument:

tags = {
  Name = "My VPN Connection"
}

Ref: https://github.com/terraform-aws-modules/terraform-aws-vpn-gateway/blob/master/main.tf#L222-L227

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.