terraform-aws-modules / terraform-aws-vpn-gateway

Terraform module to create AWS VPN gateway resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/vpn-gateway/aws
Apache License 2.0
111 stars 154 forks source link

feat: Set `vpn_connection_customer_gateway_configuration` output to `sensitive = true` #83

Closed stefan-matic closed 1 year ago

stefan-matic commented 1 year ago

Description

When creating the VPN gateway the output fails because the vpn_connection_customer_gateway_configuration has sensitive values.

│ Error: Output refers to sensitive values
│ 
│   on outputs.tf line 81:
│   81: output "vpn_connection_customer_gateway_configuration" {
│ 
│ To reduce the risk of accidentally exporting sensitive data that was
│ intended to be only internal, Terraform requires that any root module
│ output containing sensitive data be explicitly marked as sensitive, to
│ confirm your intent.
│ 
│ If you do intend to export this data, annotate the output value as
│ sensitive by adding the following argument:
│     sensitive = true

Motivation and Context

In order for the apply to go through fully, I've set the output value to be sensitive.

Existing issue that mentions several PRs that already fixed the same problem: fixes #80

Breaking Changes

No breaking changes.

How Has This Been Tested?

stefan-matic commented 1 year ago

Hello @bryantbiggs, can you let me know your thoughts on this? Do we just set the output to sensitive or did you have something else in mind?

antonbabenko commented 1 year ago

This PR is included in version 3.2.0 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.