search

terraform-aws-modules / terraform-aws-vpn-gateway

Terraform module to create AWS VPN gateway resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/vpn-gateway/aws
Apache License 2.0
111 stars 156 forks source link

Add local and remote IPv4 CIDRs parameters #84

Closed lgallard closed 1 year ago

lgallard commented 1 year ago

Description

https://github.com/binbashar/terraform-aws-vpn-gateway/pull/1

Motivation and Context

With this PR the IPv4 CIDR on the customer gateway (on-premises) side of the VPN connection and the IPv4 CIDR on the AWS side of the VPN connection can be pass as an input variable

Breaking Changes

None

How Has This Been Tested?

Tested on Binbash Leverage Reference Architecture

exequielrafaela commented 1 year ago

@lgallard thanks for this PR creation! Looking forward to have this feature available soon :)

github-actions[bot] commented 1 year ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

bryantbiggs commented 1 year ago

Is there a change that is being proposed here? Apologies, I'm a bit confused

exequielrafaela commented 1 year ago

@lgallard we probably missed to commit the proposed changes?

lgallard commented 1 year ago

@bryantbiggs @exequielrafaela when the PR was created the local_ipv4_network_cidr and remote_ipv4_network_cidr variables didn't exist (Jan 19), but later they were included in another PR (Aug 19).

I made the PR from our master branch instead of the feature branch by mistake and it also got out of date from the base branch, so I'm closing it.

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.