feat: Add `enable_tunnel_lifecycle_control` arguments

terraform-aws-modules / terraform-aws-vpn-gateway

Terraform module to create AWS VPN gateway resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/vpn-gateway/aws

Apache License 2.0

111 stars 154 forks source link

feat: Add `enable_tunnel_lifecycle_control` arguments #88

Closed visit1985 closed 1 year ago

visit1985 commented 1 year ago

Description

This PR adds the tunnel1_enable_tunnel_lifecycle_control and tunnel2_enable_tunnel_lifecycle_control arguments.

Motivation and Context

This aligns this module with the changes in upstream provider (https://github.com/hashicorp/terraform-provider-aws/issues/30706).

Breaking Changes

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects
[ ] I have executed pre-commit run -a on my pull request

antonbabenko commented 1 year ago

Looks good. Could you also update the minimum version of Terraform AWS provider to be 4.66 in all versions.tf, since the feature you're adding in this PR is pretty recent?

visit1985 commented 1 year ago

@antonbabenko, sure. Here you go.

antonbabenko commented 1 year ago

This PR is included in version 3.4.0 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.