feat: Make PSK inputs as sensitive

terraform-aws-modules / terraform-aws-vpn-gateway

Terraform module to create AWS VPN gateway resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/vpn-gateway/aws

Apache License 2.0

111 stars 156 forks source link

feat: Make PSK inputs as sensitive #91

Closed dkravetz closed 1 year ago

dkravetz commented 1 year ago

Description

Setting the tunnel PSK inputs to sensitive = true so that if Terraform errors out on a plan.

Motivation and Context

This complements PR#86, but it didn't cover the case for an erroneous plan.

Breaking Changes

None.

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

dkravetz commented 1 year ago

Am I missing something in order to get a review?

dkravetz commented 1 year ago

Some minor cleaning is needed. :)

Wonderful, thank you for the review! I've addressed your points 😄

antonbabenko commented 1 year ago

Almost. Please remove another validation block, and we are good to go.

dkravetz commented 1 year ago

Whoopsie, that one went past me 😄

antonbabenko commented 1 year ago

This PR is included in version 3.6.0 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.