search

terraform-aws-modules / terraform-aws-vpn-gateway

Terraform module to create AWS VPN gateway resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/vpn-gateway/aws
Apache License 2.0
111 stars 156 forks source link

Feature request - Outside IP address type & Transport transit gateway attachment ID #93

Closed avivmazon closed 11 months ago

avivmazon commented 1 year ago

Thanks for the hard work.

When working with direct connect and wanting to create a private IP VPN, you need to configure the "Outside IP address type" to "PrivateIpv4" and choose the Direct Connect Transit Gateway attachment.

Can you please add this feature?

cdsre commented 1 year ago

This seems like it should be an easy feature to implement. Terraform aws_vpn_connection resource support these two attributes

outside_ip_address_type - (Optional, Default PublicIpv4) Indicates if a Public S2S VPN or Private S2S VPN over AWS Direct Connect. Valid values are PublicIpv4 | PrivateIpv4
transport_transit_gateway_attachment_id - (Required when outside_ip_address_type is set to PrivateIpv4). The attachment ID of the Transit Gateway attachment to Direct Connect Gateway. The ID is obtained through a data source only.

We should be able to just set these vars in the module with a default of null which means we can define it in the resource but wont pass it unless the called explicitly sets it. I have another pull request which was a large refactor to this module. If that gets approved and merged I will then pick up this feature request. I dont have the resources to setup and test this with direct connect so I would do regression tests on the examples and then you would need to test it yourself.

avivmazon commented 1 year ago

Great! Let me know when it's merged and i will test it on my environment. Thanks.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

avivmazon commented 1 year ago

.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

avivmazon commented 1 year ago

.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] commented 11 months ago

This issue was automatically closed because of stale in 10 days

github-actions[bot] commented 10 months ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.