Closed aramatev closed 1 year ago
@bryantbiggs please advise , can you accept this? it is missing from the module, and it keeps people from setting the timeout seconds in tunnels.
@StephenKing, @nakopoulos-profile, @bryantbiggs bump, please advise, can we merge this in? do you really need me to add to examples? you've 4 types of vpn_connection resources and one of them is missing dpd_timeout_seconds for both tunnels
@antonbabenko please advise if this PR is good?
This PR is included in version 3.7.1 :tada:
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.
Description
I think this is a simple typo, you guys are missing dpd_timeout_seconds in resource "vpn_connection" tunnel_preshared for both tunnels 1 & 2
Nothing to really test, these variables are missing and its clear they are in other types of vpn_connectino resources in your file except for tunnel_preshared.
As proof - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/vpn_connection
Motivation and Context
Breaking Changes
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request