terraform-aws-modules / terraform-aws-vpn-gateway

Terraform module to create AWS VPN gateway resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/vpn-gateway/aws
Apache License 2.0
111 stars 156 forks source link

fix: Add `dpd_timeout_seconds` to `tunnel_preshared` #95

Closed aramatev closed 1 year ago

aramatev commented 1 year ago

Description

I think this is a simple typo, you guys are missing dpd_timeout_seconds in resource "vpn_connection" tunnel_preshared for both tunnels 1 & 2

Nothing to really test, these variables are missing and its clear they are in other types of vpn_connectino resources in your file except for tunnel_preshared.

As proof - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/vpn_connection

Motivation and Context

Breaking Changes

How Has This Been Tested?

aramatev commented 1 year ago

@bryantbiggs please advise , can you accept this? it is missing from the module, and it keeps people from setting the timeout seconds in tunnels.

aramatev commented 1 year ago

@StephenKing, @nakopoulos-profile, @bryantbiggs bump, please advise, can we merge this in? do you really need me to add to examples? you've 4 types of vpn_connection resources and one of them is missing dpd_timeout_seconds for both tunnels

aramatev commented 1 year ago

@antonbabenko please advise if this PR is good?

antonbabenko commented 1 year ago

This PR is included in version 3.7.1 :tada:

github-actions[bot] commented 12 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.