search

terraform-community-modules / tf_aws_elasticsearch

[DEPRECATED] Use https://github.com/terraform-aws-modules/terraform-aws-opensearch
MIT License
79 stars 97 forks source link

The term "dedicated_master_type" is misleading #34

Closed actionjack closed 5 years ago

actionjack commented 5 years ago

The term "dedicated_master_type" is a little misleading in the documentation it seems to suggest that it is either a string for the machine type or a boolean. Which is it supposed to be?

lipingtababa commented 5 years ago

I think the terms are defined by AWS team rather than terraform team. https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-elasticsearch-domain-elasticsearchclusterconfig.html If you put these 3 configurations together, then they are obvious.

"DedicatedMasterEnabled" : Boolean, "DedicatedMasterType" : String, "DedicatedMasterCount" : Integer,

antonbabenko commented 5 years ago

This has been fixed in v1.2.0 where dedicated_master_type is now a string.