terraform-community-modules / tf_aws_elasticsearch

[DEPRECATED] Use https://github.com/terraform-aws-modules/terraform-aws-opensearch
MIT License
79 stars 97 forks source link

Add `dynamic` condition to inject or not `awarness_config` block #41

Closed sshishov closed 4 years ago

sshishov commented 4 years ago

The solution is to dynamically inject awarness_config block based on the variable.

Sources: https://www.hashicorp.com/blog/hashicorp-terraform-0-12-preview-for-and-for-each/#dynamic-nested-blocks

Fixes #40

asobrien commented 4 years ago

This is exactly what I need! I have this patch applied on my tree and can confirm it's working.

sshishov commented 4 years ago

Hey guys, can we have this PR merged? Meanwhile on our production has to use the fork.

mr-smithers-excellent commented 4 years ago

Would be great to get this merged!

benjefferies commented 4 years ago

Great PR. Would be good to get in?

antonbabenko commented 4 years ago

Here we go! v1.3.0 of this module has been just released.

benjefferies commented 4 years ago

Feels good to see this

No changes. Infrastructure is up-to-date.