search

terraform-community-modules / tf_aws_vpc

[DEPRECATED] Use https://github.com/terraform-aws-modules/terraform-aws-vpc
Other
211 stars 203 forks source link

Make the module compatible with terraform v0.7.0 #13

Closed ainestal closed 8 years ago

ainestal commented 8 years ago

Make the module compatible with v0.7.0 by creating lists for public and private networks, instead of strings. Also create a list for AZS instead of a string.

antonbabenko commented 8 years ago

Will this PR try to recreate already created resources?

ainestal commented 8 years ago

@antonbabenko it didn't try to re-create anything in my tests. It was able to detect existing resources and respect them

ainestal commented 8 years ago

@antonbabenko : No, It doesn't recreate created resources. I've been using the modified module successfully for 3 days now with different VPCs in different environments and everything works fine.

antonbabenko commented 8 years ago

This is a good update. I will give it a try on my setup on Monday and merge it.

ainestal commented 8 years ago

@antonbabenko just 1 note, the module probably will not be compatible with previous v0.6.16 anymore. But terraform files working with v0.7.0 are not compatible anyway (mines weren't) so I guess it not a big problem.

antonbabenko commented 8 years ago

I was thinking a bit about compatibility and I think if we keep master branch compatible with latest stable version of Terraform it should be good. For previous versions people should reference to previous tags.

ainestal commented 8 years ago

@antonbabenko that makes sense to me. But it should be explained in the doc. It also should be explained how to do it; when I'm importing the module I'm referencing the url of the repository without specifying any specific branch or commit. It can be confusing for people suddenly needing to specify some extra details for their module to continue working with their existing terraform (pre v0.7)

antonbabenko commented 8 years ago

Thank you very much. I have also updated few other modules here - https://github.com/terraform-community-modules/