terraform-community-modules / tf_aws_vpc

[DEPRECATED] Use https://github.com/terraform-aws-modules/terraform-aws-vpc
Other
210 stars 203 forks source link

feature(rds): add rds database subnets #36

Closed nyambati closed 7 years ago

nyambati commented 7 years ago

Changes introduces by this PR

When building a VPC you may require to add RDS instances into your infrastructure. This might require isolated private subnet groups apart from the existing ones. Below are the changes introduced by this PR.

usage

module "vpc" {
...
  database_subnets   = ["10.0.90.0/24", "10.0.91.0/24", "10.0.92.0/24"]
....
}

Terraform will only provision these resources only when the variable database_subnets is provided.

antonbabenko commented 7 years ago

Also, please update README.

nyambati commented 7 years ago

@antonbabenko I have made the updates, It should be all good now. Thanks for the review.

tfhartmann commented 7 years ago

Would someone mind tagging a new release?

antonbabenko commented 7 years ago

Done. https://github.com/terraform-community-modules/tf_aws_vpc/releases/tag/v1.0.3