search

terraform-community-modules / tf_aws_vpc

[DEPRECATED] Use https://github.com/terraform-aws-modules/terraform-aws-vpc
Other
211 stars 203 forks source link

Adjusted count of NAT gateways to be dependent upon the number of AZs #44

Closed dyindude closed 7 years ago

dyindude commented 7 years ago

I was using this module for a project that had 9 private subnets and was frustrated when I found I also had 9 NAT gateways.

This change will create one NAT gateway per AZ and the private subnets will end up with routes to the NAT gateway in the same AZ.

This is related to issue #42

bendavies commented 7 years ago

@antonbabenko any chance of merging this?

antonbabenko commented 7 years ago

@bendavies I didn't have a chance to try out this PR myself.

If you (or anyone other than code submitter) can maybe try to run this code in your setup and confirm that it works as expected then we can merge it right away.

The reason why I think we need to run code before merging is that there are a lot of people using master branch of this module already and we should not break it for them.

bendavies commented 7 years ago

@antonbabenko thanks, will do. Will try to get back to you by tomorrow

analytically commented 7 years ago

Any progress on this issue?

antonbabenko commented 7 years ago

LGTM. I will merge now.

antonbabenko commented 7 years ago

Thanks all!

I have just created tag for this release - https://github.com/terraform-community-modules/tf_aws_vpc/releases/tag/v1.0.6

If you want to use the previous version, use this tag - https://github.com/terraform-community-modules/tf_aws_vpc/releases/tag/v1.0.5

dyindude commented 7 years ago

Thanks!