search

terraform-community-modules / tf_aws_vpc

[DEPRECATED] Use https://github.com/terraform-aws-modules/terraform-aws-vpc
Other
211 stars 203 forks source link

Adding a Tier tag to all subnets #50

Closed tfhartmann closed 7 years ago

tfhartmann commented 7 years ago

By adding a static "Tier" tag, this should make using the TF subnet_ids data source easier to use with this module.

See https://www.terraform.io/docs/providers/aws/d/subnet_ids.html

With this comment, it should make it easier to preform this action and retrieve lists of subnet id's that can then be passed into other resources as needed. 

data "aws_subnet_ids" "private" {
  vpc_id = "${var.vpc_id}"
  tags {
    Tier = "private"
  }
}
tfhartmann commented 7 years ago

Hi there, I just wanted to nudge this. Is this contributions something that would be useful to other folks using this module?

antonbabenko commented 7 years ago

I think this PR is fine, as long as there are no better ways (more flexible) to customise tags. Also, this PR is backward compatible, which means it is safe to merge.

tfhartmann commented 7 years ago

Cool! @phinze if you concur, would be willing to merge? Sorry to keep nudging but having this would help us with a bit of work we are doing :) and I'd way rather keep using the upstream tag'd releases of this module!

phinze commented 7 years ago

Sure! LGTM

tfhartmann commented 7 years ago

Awesome! You are my hero! Could I ask you to push a new tag as well?

antonbabenko commented 7 years ago

@tfhartmann You should be able to do this yourself from now on.

tfhartmann commented 7 years ago

@antonbabenko Thanks!