Support subnet-specific additional tags

terraform-community-modules / tf_aws_vpc

[DEPRECATED] Use https://github.com/terraform-aws-modules/terraform-aws-vpc

Other

210 stars 203 forks source link

Support subnet-specific additional tags #51

Closed rmt closed 7 years ago

rmt commented 7 years ago

Added var.public_subnet_tags
Added var.private_subnet_tags
Added var.database_subnet_tags
Added var.elasticache_subnet_tags

This helps solve a specific issue with Kubernetes, where public & private subnets must be appropriately tagged for public/private ELBs to work.

rmt commented 7 years ago

I'd also be fine with removing the "Tier" tag in favour of only using this (more flexible) mechanism, but I didn't want to break an existing feature.

tfhartmann commented 7 years ago

I wouldn't be opposed to replacing the Tier tag with this, this looks more flexible then what I did, and it looks like would could still pass Tier => dev in as a map. We could always cut a major version release if we are worried about breaking backward compatibility.

rmt commented 7 years ago

I've updated the commit to remove the Tier tag, and to change the ordering (so that the Name tag comes last again).

rmt commented 7 years ago

Is there anything that I should do for this to be merged?

antonbabenko commented 7 years ago

@rmt Normally is should not take so long to get code merged. Thank you!

tfhartmann commented 7 years ago

@rmt sorry about that! @antonbabenko thanks for getting this merged!