search

terraform-community-modules / tf_aws_vpc

[DEPRECATED] Use https://github.com/terraform-aws-modules/terraform-aws-vpc
Other
210 stars 203 forks source link

🐛 #47 Fix issue with string vs bool value with enable_nat_gateway input #57

Closed n8io closed 7 years ago

n8io commented 7 years ago

Prior to this change, only this input value would create NAT gateways:

module "vpc" {
  source = "github.com/terraform-community-modules/tf_aws_vpc"

  enable_nat_gateway = "true"
  ...
}

After this change, any of these input values will create NAT gateways:

module "vpc" {
  source = "github.com/terraform-community-modules/tf_aws_vpc"

  enable_nat_gateway = "true"
  enable_nat_gateway = "1"
  enable_nat_gateway = true
  enable_nat_gateway = 1
  ...
}

...and conversly these will not create any NAT gateways:

module "vpc" {
  source = "github.com/terraform-community-modules/tf_aws_vpc"

  enable_nat_gateway = "false"
  enable_nat_gateway = "0"
  enable_nat_gateway = false
  enable_nat_gateway = 0
  ...
}
n8io commented 7 years ago

@williamtsoi1 saw you merged code recently. Can you review/merge?

williamtsoi1 commented 7 years ago

LGTM - but I don't have access to merge this PR :(

antonbabenko commented 7 years ago

Merged, the new release has been tagged as v1.0.10.